RC 2.8.0 - ACB Time Stamp is Incorrect
-
I posted this originally in another topic ACB Backup Time Update but cannot delete it, I think it is better in this Topic.
I updated to pfSense 2.8.0 RC the other day and noticed when I went through the settings that the time stamp in the ACB Service (Services/Auto Configuration Backup/Restore) is behind my time by 7 hours.
I check my time and it is correct for time and zone in the Dashboard.
I changed the time zone temporarily but the time stamp did not change in ACB but the zone did, i.e. it was +0200 for CEST and when I changed it to ETC/UTC time zone it went to +0000 but time itself did not change.
I have this issue on 2 pfsense setups I have running at home.
I did some researching and only found the reference to the LINK above ACB Backup Time Update to the issue.
So, am I doing something wrong in my setups or is this a know issue for pfSense 2.8.0 RC?
-
Hmm, yup seeing that. Digging....
-
-
Looks like a variable name change was missed. Try:
diff --git a/src/etc/inc/acb.inc b/src/etc/inc/acb.inc index daa5a27c4e7472548338a4bd566ae30524f7db6f..7e82d436488c077547c9248e2e3cb15be5f2ff9f 100644 --- a/src/etc/inc/acb.inc +++ b/src/etc/inc/acb.inc @@ -160,8 +160,8 @@ function acb_check_dns() { /* Change the time zone to reflect local time of ACB revisions. * See Redmine #5250 */ function acb_time_shift($revision, $format = DATE_RFC2822) { - global $acbtz; - $budate = new DateTime($revision, $acbtz); + global $acb_server_tz; + $budate = new DateTime($revision, $acb_server_tz); $mytz = new DateTimeZone(date_default_timezone_get()); $budate->setTimezone($mytz); return htmlspecialchars($budate->format($format));
-
@stephenw10 said in RC 2.8.0 - ACB Time Stamp is Incorrect:
Looks like a variable name change was missed. Try:
diff --git a/src/etc/inc/acb.inc b/src/etc/inc/acb.inc index daa5a27c4e7472548338a4bd566ae30524f7db6f..7e82d436488c077547c9248e2e3cb15be5f2ff9f 100644 --- a/src/etc/inc/acb.inc +++ b/src/etc/inc/acb.inc @@ -160,8 +160,8 @@ function acb_check_dns() { /* Change the time zone to reflect local time of ACB revisions. * See Redmine #5250 */ function acb_time_shift($revision, $format = DATE_RFC2822) { - global $acbtz; - $budate = new DateTime($revision, $acbtz); + global $acb_server_tz; + $budate = new DateTime($revision, $acb_server_tz); $mytz = new DateTimeZone(date_default_timezone_get()); $budate->setTimezone($mytz); return htmlspecialchars($budate->format($format));
Patch worked well, ACB Restore timestamps are now reflecting local time set in pfSense.
Thanks.